frame-omni-bencher maintenance #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Aug 26, 2024
prdoc/pr_5466.prdoc
Outdated
| - audience: Runtime Dev | ||
| description: "Changes:\r\n- Set default level to `Info` again. Seems like a dependency\ | ||
| \ update set it to something higher.\r\n- Fix docs to not use `--locked` since\ | ||
| \ we rely on dependency bumps via cargo.\r\n- Add README with rust docs." |
There was a problem hiding this comment.
First time trying out the bot. Looks a bit mangled 😅
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Aug 26, 2024
lexnv
approved these changes
Aug 26, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
the
A4-needs-backport
ordian
added a commit
that referenced
this pull request
Aug 29, 2024
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
ggwpez
added
A4-needs-backport
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable2407
git worktree add -d .worktree/backport-5466-to-stable2407 origin/stable2407
cd .worktree/backport-5466-to-stable2407
git switch --create backport-5466-to-stable2407
git cherry-pick -x 7e7c33453eeb14f47c6c4d0f98cc982e485edc77 |
ggwpez
added
A4-needs-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5466-to-stable2407
git worktree add --checkout .worktree/backport-5466-to-stable2407 backport-5466-to-stable2407
cd .worktree/backport-5466-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 7e7c33453eeb14f47c6c4d0f98cc982e485edc77
git push --force-with-lease |
ggwpez
added a commit
that referenced
this pull request
Aug 29, 2024
Changes: - Set default level to `Info` again. Seems like a dependency update set it to something higher. - Fix docs to not use `--locked` since we rely on dependency bumps via cargo. - Add README with rust docs. - Fix bug where the node ignored `--heap-pages` argument. You can test the `--heap-pages` bug by running this command on master and then on this branch. Note that it should fail because of the very low heap pages arg: `cargo run --release --bin polkadot --features=runtime-benchmarks -- benchmark pallet --chain=dev --steps=10 --repeat=30 --wasm-execution=compiled --heap-pages=8 --pallet=frame-system --extrinsic="*"` --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: ggwpez <ggwpez@users.noreply.github.com> (cherry picked from commit 7e7c334)
ggwpez
removed
the
A4-needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Infoagain. Seems like a dependency update set it to something higher.--lockedsince we rely on dependency bumps via cargo.--heap-pagesargument.You can test the
--heap-pagesbug by running this command on master and then on this branch. Note that it should fail because of the very low heap pages arg:cargo run --release --bin polkadot --features=runtime-benchmarks -- benchmark pallet --chain=dev --steps=10 --repeat=30 --wasm-execution=compiled --heap-pages=8 --pallet=frame-system --extrinsic="*"